View Full Version : SOLVED: shift+click to open forums in a new window - Not working?
blindbug
09-03-2006, 08:09 AM
This is something that is grandfathered from Slickdeals Original. I am a man that likes to open multiple forums at once in multiple windows (I don't use tabs, I use new windows). When you right click on a subforum in the forum, you can click 'open in a new window' and it will work, but unfortunately when you hold shift and then click, it opens the forum in a new window AND in the originating window. This has been a peeve of mine for a long time with Slickdeals, but thought I would mention it as the new changes are being worked out.
I use shift+click on other sites without issue all the time, it's my kryptonite here in SD, please fix this, pretty please :).
Oh yeah, I also noticed that shift+click works for the actual posts in a forum, but not in the main forum window?
shoitz
09-03-2006, 08:27 AM
This is something that is grandfathered from Slickdeals Original. I am a man that likes to open multiple forums at once in multiple windows (I don't use tabs, I use new windows). When you right click on a subforum in the forum, you can click 'open in a new window' and it will work, but unfortunately when you hold shift and then click, it opens the forum in a new window AND in the originating window. This has been a peeve of mine for a long time with Slickdeals, but thought I would mention it as the new changes are being worked out.
I use shift+click on other sites without issue all the time, it's my kryptonite here in SD, please fix this, pretty please :).
Oh yeah, I also noticed that shift+click works for the actual posts in a forum, but not in the main forum window?
As far as I can tell, this isn't true... I tried in firefox and IE (I figured you were using one of the two), and shift-click worked for me every time. Now the caveat to that is that on the forums page (beta.slickdeals.net/forums or forums.slickdeals.net) you have to shift-click the actual link--ie the blue text name of the sub forum, like the blue text for "Hot Deals" to get it to open in a new window.
The bug, as far as I can tell, is that when you shift-click on the sub-forums, it will open the subforum in a new window, but also transfer you to the sub-forum in the original window as well. This is (most likely) due to the field properties that allow you to click anywhere in the small box surrounding the link to the sub-form and still be transferred to that sub-forum.
Hope I didn't ramble too much, and blindbug, sorry if that's what you were getting at already :)
OK, so i *think* this is the line causing this behavior:
<td class="alt1" align="left" id="f9" onMouseOver="this.className='alt1Active cursor';" onMouseOut="this.className='alt1';" onclick="window.location.href='forumdisplay.php?sduid=119763&f=9'">
<a href="forumdisplay.php?sduid=119763&f=9"><strong>Hot Deals</strong></a>
with the bolded section being suspect, IMO. Easiest fix would be to make some sort of "on shift click" exception, if such a thing is possible ( shoitz != a programmer/web designer :lmao: )
blindbug
09-03-2006, 09:29 AM
What you are saying is what I am experiencing. The post links inside the forums work with shift+click, but the subforums on forums.slickdeals.net do not work correctly (opening in the new window and also in the originating window). I too see that this is a problem with the javascript backend on the forums.
A true solution to this is to use CSS and block-style linking, it would give the exact same effect, and would probably simplify the processes, while allowing shift+click to work correctly. Which is the reason I was suggesting this change at this time. In Slickdeals Original, the block-style links were handled via javascript (the main menu along the top has javascript style linking) but in Slickdeals Beta, these links have moved to the more updated CSS block-style linking, allowing me to shift+click to my hearts content along the top menu, which I could not do before.
I know this may sound confusing if you don't know html/css/java/etc, but the developers should be able to follow me :P.
shoitz
09-03-2006, 10:04 AM
What you are saying is what I am experiencing. The post links inside the forums work with shift+click, but the subforums on forums.slickdeals.net do not work correctly (opening in the new window and also in the originating window). I too see that this is a problem with the javascript backend on the forums.
A true solution to this is to use CSS and block-style linking, it would give the exact same effect, and would probably simplify the processes, while allowing shift+click to work correctly. Which is the reason I was suggesting this change at this time. In Slickdeals Original, the block-style links were handled via javascript (the main menu along the top has javascript style linking) but in Slickdeals Beta, these links have moved to the more updated CSS block-style linking, allowing me to shift+click to my hearts content along the top menu, which I could not do before.
I know this may sound confusing if you don't know html/css/java/etc, but the developers should be able to follow me :P.
Nope, I followed 100% :) I've done some programming and web design, I just don't really like doing it so it's not exactly a hobby of mine, but I know more than enough to get by. And yes, I agree with your prognosis as well. Shift+click doesn't really affect me b/c I just middle click for a new tab most of the times, and ctrl+N when I get too many tabs and need a new window, but it's obviously still good coding to fix things like this.
slickdeals
09-05-2006, 01:48 AM
CSS fix doesn't work but detecting the shift key with js works.
blindbug
09-06-2006, 10:15 AM
CSS fix doesn't work but detecting the shift key with js works.
AWESOME! Thanks much!